Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "reply to message" now takes usernames with @'s & commas into consideration #5173

Merged
merged 4 commits into from
Feb 17, 2024

Conversation

KleberPF
Copy link
Contributor

This fixes not being able to reply to an user if you are already mentioning them before the reply action. Here are the possibilities:

Regular mesage

Before reply action

image

After reply action

image

Mentioning user with a comma

Before reply action

image

After reply action

image

Mentioning user without a comma

Before reply action

image

After reply action

image

Mentioning user with a comma and with text after it

Before reply action

image

After reply action

image

Mentioning user without a comma and with text after it

Before reply action

image

After reply action

image

Fixes #5171

@Felanbird
Copy link
Collaborator

- Bugfix: Fixed an issue where you had to click the `reply` button twice if you already had that users @ in your input box. (#5173)

I like this entry because I noticed it when testing the original report, and it feels possible that this is the problem users saw

@pajlada pajlada changed the title Fix reply not working when already mentioning user in reply (#5171) fix: "reply to message" now takes usernames with @'s & commas into consideration Feb 17, 2024
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I added some unit tests, if you can think of any additional unit tests that should or should not work, feel free to add those

@pajlada pajlada enabled auto-merge (squash) February 17, 2024 13:04
@pajlada pajlada merged commit 42e4559 into Chatterino:master Feb 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reply does not work if you already have @name, inside chatbox
3 participants