Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eventsub): compilation issues #5212

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Feb 27, 2024

Compiling the library as an object library causes some object files to not be linked to the final executable if it depends on the library transitively. Compiling the library as a static library (like other libraries) solves this. I don't know why the default is an object library.

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Feb 27, 2024

Remaining issues:

@pajlada
Copy link
Member

pajlada commented Feb 27, 2024

At least Boost 1.83 is required for boost::json::try_value_to( value const&, Context const&) (Ubuntu uses 1.81)

Once Chatterino/docker@ea62e3c CI is done, Ubuntu builds will use Boost 1.84

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Feb 28, 2024

Once Chatterino/docker@ea62e3c CI is done, Ubuntu builds will use Boost 1.84

The docker image doesn't appear to be pushed.

@pajlada
Copy link
Member

pajlada commented Feb 28, 2024

hopefully will be fixed by Chatterino/docker#8 xd

@Nerixyz Nerixyz changed the title fix(eventsub): compile twitch-eventsub-ws as a static library fix(eventsub): compilation issues Feb 28, 2024
@pajlada pajlada merged commit 0e9c193 into Chatterino:chore/eventsub Mar 2, 2024
16 checks passed
@Nerixyz Nerixyz deleted the fix/chore/eventsub branch March 2, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants