Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly load twitch badges in highlights page #5223

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 2, 2024

Broken state:
image

Fixed state after this PR:
image

@pajlada
Copy link
Member Author

pajlada commented Mar 2, 2024

image

@pajlada pajlada enabled auto-merge (squash) March 2, 2024 10:43
@kornes
Copy link
Contributor

kornes commented Mar 2, 2024

in what way #3736 broke it?
imageCount() == 0 check was present before my PR, so unless it reports -1 now (which is error value we probably shouldn't ignore), it was broken before

@pajlada
Copy link
Member Author

pajlada commented Mar 2, 2024

in what way #3736 broke it? imageCount() == 0 check was present before my PR, so unless it reports -1 now (which is error value we probably shouldn't ignore), it was broken before

My bad, I checked the diff too lazily then

@pajlada pajlada disabled auto-merge March 2, 2024 11:01
@pajlada pajlada enabled auto-merge (squash) March 2, 2024 11:01
@pajlada pajlada merged commit 3928cc9 into master Mar 2, 2024
17 checks passed
@pajlada pajlada deleted the fix/badge-highlights-not-loading branch March 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants