Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to duplicate tabs #5277

Merged
merged 17 commits into from
May 25, 2024
Merged

Add feature to duplicate tabs #5277

merged 17 commits into from
May 25, 2024

Commits on May 18, 2024

  1. Add feature to duplicate tabs

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3660d5a View commit details
    Browse the repository at this point in the history

  2. Convert Channel::Type to string

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1cd45ee View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary assert and include

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    be1e67e View commit details
    Browse the repository at this point in the history

  4. Copy highlight state before setting + rebase

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    e786dc1 View commit details
    Browse the repository at this point in the history

  5. Re-add pajlada's changes

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3d836c3 View commit details
    Browse the repository at this point in the history

  6. Get channel type from indirect channel

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    97b7eea View commit details
    Browse the repository at this point in the history

  7. Allow duplicating empty tab + fix formatting

    @KleberPF
    KleberPF committed May 18, 2024
    Configuration menu
    Copy the full SHA
    a87da55 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Add check to only build descriptor if tab has split

    @KleberPF
    KleberPF committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7058ccf View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. nit: add missing includes

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    ff2b728 View commit details
    Browse the repository at this point in the history

  2. nit: defensive where we assert

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    4b9f3f7 View commit details
    Browse the repository at this point in the history

  3. nit: use -1 as the default dupe tab position 

    this shouldn't be able to fail, but this is a bit more "defensive"
    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    09b0f7a View commit details
    Browse the repository at this point in the history

  4. nit: rename highlightState

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    6741f2e View commit details
    Browse the repository at this point in the history

  5. nit: move new tab bible logic out to a variable

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    4eec87e View commit details
    Browse the repository at this point in the history

  6. nit: constify

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a0ff5fa View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into feature-duplicate-tab

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    d702333 View commit details
    Browse the repository at this point in the history

  8. nit: Add changelog entry

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    f5f5549 View commit details
    Browse the repository at this point in the history

  9. fix: actually constify xd

    @pajlada
    pajlada committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a408bf4 View commit details
    Browse the repository at this point in the history