Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: Change CompletionRequested handler to use an event table. #5280

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Mar 30, 2024

If we want to add additional data, we can just do it now without breaking anything or problems.
This is basically the last change I want to do before releasing a public alpha.

@Mm2PL Mm2PL requested a review from pajlada March 30, 2024 13:41
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/plugins/LuaUtilities.cpp Show resolved Hide resolved
@Mm2PL Mm2PL enabled auto-merge (squash) March 30, 2024 13:56
@Mm2PL Mm2PL merged commit d4b8fea into master Mar 30, 2024
17 checks passed
@Mm2PL Mm2PL deleted the feature/completion-event-use-table-not-tons-of-params branch March 30, 2024 14:23
Mm2PL added a commit to Mm2PL/supibot-completion-plugin that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants