chore: remove Singleton & replace getIApp with getApp #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
chore/unsingletonize-more-things
branch
from
383ec13
to
044996e
Compare
pajlada
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Singletonbase class of the remaining controllers/singletons, and manually calls their initialize/save if necessary instead, with only the necessary parameters.With this change, I've gone made the
getApp()function call return theIApplication*interface (likegetIApp()did), so we can have one single "get god class" function.It's been possible for a little bit already, but now everything that must be accessible is accessible through the
IApplicationinterface