Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"no such file or directory" for report-path #200

Closed
baruchiro opened this issue Feb 11, 2024 · 0 comments · Fixed by #207
Closed

"no such file or directory" for report-path #200

baruchiro opened this issue Feb 11, 2024 · 0 comments · Fixed by #207
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@baruchiro
Copy link
Contributor

Try to run 2ms with output to a non-existing folder, for example:

./2ms confluence 'https://checkmarx.atlassian.net/wiki' --spaces secrets --report-path results/confluence.yaml

You will get the next error:

Error: failed to create report file with error: open results/confluence.yaml: no such file or directory

We need to create this folder if it does not exist.
@baruchiro baruchiro added bug Something isn't working good first issue Good for newcomers labels Feb 11, 2024
nargov added a commit to nargov/2ms that referenced this issue Feb 17, 2024
@nargov
fixes Checkmarx#200 by adding a check that the path exists and if not…
39f09aa 
… create it
@nargov nargov mentioned this issue Feb 17, 2024
Merged
nargov added a commit to nargov/2ms that referenced this issue Feb 18, 2024
@nargov
fixes Checkmarx#200 by adding a check that the path exists and if not…
309dc3c 
… create it
nargov added a commit to nargov/2ms that referenced this issue Feb 18, 2024
@nargov
fixes Checkmarx#200 by adding a check that the path exists and if not…
cc922e2 
… create it
nargov added a commit to nargov/2ms that referenced this issue Feb 18, 2024
@nargov
fixes Checkmarx#200 by adding a check that the path exists and if not…
d39383d 
… create it
@baruchiro baruchiro mentioned this issue Feb 19, 2024
Closed
nargov added a commit to nargov/2ms that referenced this issue Feb 20, 2024
@nargov
fixes Checkmarx#200 by adding a check that the path exists and if not…
8ec48b4 
… create it
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2024
@nargov
fix: report directory is not exist (#207)
9fe6a3d 
Closes #200 

I would usually start a discussion about a change before starting, but
since this was just a tiny fix I skipped it this time. Hope that's Ok.

This adds a path existence check to the path(s) passed in and ensures
the directory exists.

I submit this contribution under the Apache-2.0 license.

Co-authored-by: Baruch Odem (Rothkoff) <baruch.odem@checkmarx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: report directory is not exist nargov/2ms
1 participant
@baruchiro