Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add special rules with hardcoded-password rule #181

Merged
merged 8 commits into from
Sep 12, 2023
Merged

feat: add special rules with hardcoded-password rule #181

merged 8 commits into from
Sep 12, 2023

Conversation

baruchiro
Copy link
Contributor

  • add hardcoded-password rule
  • feat: add special (non-default) rules with hardcoded-password rule

Fix #80
Close #174

@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.6

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

@baruchiro baruchiro changed the title feat: add special (non-default) rules with hardcoded-password rule feat: add special rules with hardcoded-password rule Sep 12, 2023
@baruchiro baruchiro force-pushed the optional-rule-for-hardcoded-password branch from f9f3e7e to 8d3bba9 Compare September 12, 2023 10:29
jossef
jossef requested changes Sep 12, 2023
View reviewed changes
README.md
## Special Rules

Special rules are rules that are not part of the default ruleset, usually because they are too noisy or too specific. You can use the `--add-special-rule` flag to add special rules by rule ID.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a simple markdown table (as used below) with name, description columns
add line to describe hardcoded-password rule

@baruchiro baruchiro force-pushed the optional-rule-for-hardcoded-password branch from 4123bae to c85bdaa Compare September 12, 2023 13:08
@baruchiro baruchiro merged commit 69e9383 into master Sep 12, 2023
7 checks passed
@baruchiro baruchiro deleted the optional-rule-for-hardcoded-password branch September 12, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jossef jossef jossef requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@baruchiro @jossef