Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Kubernetes query 'Service Does Not Target Pod' #2793 #2881

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Fixed Kubernetes query 'Service Does Not Target Pod' #2793 #2881

merged 2 commits into from
Apr 19, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota joao.reigota@checkmarx.com

Closes #2793

Proposed Changes

  • Updated query Service Does Not Target Pod
  • Query will now look for pods defined inside the template of a StatefulSet

I submit this contribution under Apache-2.0 license.

@joaoReigota1
Updated query Service Does Not Target Pod #2793
f317e45 
Signed-off-by: João Reigota <joao.reigota@checkmarx.com>
@joaoReigota1 joaoReigota1 added bug Something isn't working query New query feature kubernetes Kubernetes query labels Apr 19, 2021
@joaoReigota1 joaoReigota1 added this to the Queries Support milestone Apr 19, 2021
@joaoReigota1 joaoReigota1 self-assigned this Apr 19, 2021
@joaoReigota1 joaoReigota1 added this to In progress in KICS Queries via automation Apr 19, 2021
@rafaela-soares rafaela-soares force-pushed the feature/update_service_does_not_target_pod branch 3 times, most recently from 61f6ad9 to f317e45 Compare April 19, 2021 12:00
rogeriopeixotocx
rogeriopeixotocx approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit e743e17 into master Apr 19, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/update_service_does_not_target_pod branch April 19, 2021 15:59
@rogeriopeixotocx rogeriopeixotocx changed the title Updated query Service Does Not Target Pod #2793 Fixed Kubernetes query 'Service Does Not Target Pod' #2793 Apr 21, 2021
@rogeriopeixotocx rogeriopeixotocx moved this from In progress to Done in KICS Queries May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@rafaela-soares rafaela-soares Awaiting requested review from rafaela-soares

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@joaoReigota1 joaoReigota1

Labels
bug Something isn't working kubernetes Kubernetes query query New query feature
Projects
KICS Queries
Done
Milestone
Queries Support
Development

Successfully merging this pull request may close these issues.

K8S - Query - Service Does Not Target Pod - incorrect result
3 participants
@joaoReigota1 @rogeriopeixotocx @rafaela-soares