Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): Fix invalid log path not returning error #3155 #3290

Merged
merged 1 commit into from May 12, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota joao.reigota@checkmarx.com

Closes #3155

Proposed Changes

  • remove filepath.Clean from log path

I submit this contribution under the Apache-2.0 license.

Signed-off-by: João Reigota <joao.reigota@checkmarx.com>
@joaoReigota1 joaoReigota1 added the bug Something isn't working label May 12, 2021
@joaoReigota1 joaoReigota1 self-assigned this May 12, 2021
@joaoReigota1 joaoReigota1 added this to In progress in KICS Engine via automation May 12, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 12, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 12, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 90ab12e into master May 12, 2021
KICS Engine automation moved this from In progress to Done May 12, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/invalid_log_path_no_error branch May 12, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

On invalid log path - log is created in cwd
3 participants