Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Fixed Bug with invalid terraform returning panic #3304 #3305

Merged
merged 1 commit into from May 13, 2021
Merged

fix(parser): Fixed Bug with invalid terraform returning panic #3304 #3305

merged 1 commit into from May 13, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota joao.reigota@checkmarx.com

Closes #3304

Proposed Changes

  • Fixed Bug with invalid terraform returning panic
  • Invalid files will now only be logged instead of returning an error

I submit this contribution under the Apache-2.0 license.

@joaoReigota1
Fixed Bug with invalid terraform returning panic #3304
11179ed 
Signed-off-by: João Reigota <joao.reigota@checkmarx.com>
@joaoReigota1 joaoReigota1 added bug Something isn't working go Pull requests that update Go code labels May 13, 2021
@joaoReigota1 joaoReigota1 self-assigned this May 13, 2021
@joaoReigota1 joaoReigota1 added this to In progress in KICS Engine via automation May 13, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 13, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 13, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

rogeriopeixotocx
rogeriopeixotocx approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 481398b into master May 13, 2021
KICS Engine automation moved this from In progress to Done May 13, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_terraform_parser branch May 13, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@rafaela-soares rafaela-soares Awaiting requested review from rafaela-soares

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@joaoReigota1 joaoReigota1

Labels
bug Something isn't working go Pull requests that update Go code
Projects
KICS Engine
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Terraform returning panic
3 participants
@joaoReigota1 @kicsbot @rogeriopeixotocx