Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(report): hide secrets in report results #5504

Merged
merged 2 commits into from
Jul 28, 2022
Merged

feat(report): hide secrets in report results #5504

merged 2 commits into from
Jul 28, 2022

Conversation

rafaela-soares
Copy link
Contributor

@rafaela-soares rafaela-soares commented Jun 21, 2022 •
edited
Loading

Issue #4975 will be closed when the branch release/1.6 is merged into the master.

Proposed Changes

  • hide secrets in report results

As an example:

image

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added feature request Community: new feature request go Pull requests that update Go code labels Jun 21, 2022
@rafaela-soares rafaela-soares added this to the Reporting milestone Jun 21, 2022
@rafaela-soares rafaela-soares added this to In progress in KICS Engine via automation Jun 21, 2022
@rafaela-soares rafaela-soares self-assigned this Jun 21, 2022
@nunoocx
Copy link
Collaborator

nunoocx commented Jun 23, 2022

@rafaela-soares, is there a way of masking only the actual secret?
I mean when the line is
"secret" = "Abcao93n3o89h0n03"
we would show:
"secret" = "<SECRET-MASKED-ON-PURPOSE"

nunoocx
nunoocx approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@nunoocx nunoocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares merged commit 95a4bad into release/1.6 Jul 28, 2022
KICS Engine automation moved this from In progress to Done Jul 28, 2022
@rafaela-soares rafaela-soares deleted the feat/hide_secrets_in_report_results branch July 28, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunoocx nunoocx nunoocx approved these changes

@joaoReigota1 joaoReigota1 Awaiting requested review from joaoReigota1

Assignees

@rafaela-soares rafaela-soares

Labels
feature request Community: new feature request go Pull requests that update Go code release/1.6
Projects
KICS Engine
Done
Milestone
Reporting
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafaela-soares @nunoocx