fix(keyExpectedValue): cloudformation-aws queries convert to a recommendation rather than a current status - stage 2 #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endation rather than a current status - stage 2
rafaela-soares
suggested changes
Jul 28, 2022
There was a problem hiding this comment.
Hello again, @liorj-orca!
Thank you so much for another PR 🚀
This PR is also failing in the E2E tests. If you need any help, let me know 😊
...ation/aws/directory_service_microsoft_ad_password_set_to_plaintext_or_default_ref/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/cloudFormation/aws/ec2_permissive_network_acl_protocols/query.rego
Show resolved
Hide resolved
|
Hello, @liorj-orca! |
…lue_cloudFormation_aws_2
cxMiguelSilva
approved these changes
Aug 23, 2022
rafaela-soares
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…endation rather than a current status - stage 2
Closes #
Proposed Changes
I submit this contribution under the Apache-2.0 license.