Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(memory consumption): improved SplitLines function calls #5680

Merged
merged 8 commits into from Aug 26, 2022
Merged

fix(memory consumption): improved SplitLines function calls #5680

merged 8 commits into from Aug 26, 2022

Conversation

rafaela-soares
Copy link
Contributor

Proposed Changes

  • improved SplitLines function calls
  • improved minor code details

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the go Pull requests that update Go code label Aug 8, 2022
@rafaela-soares rafaela-soares self-assigned this Aug 8, 2022
@rafaela-soares rafaela-soares added this to In progress in KICS Engine via automation Aug 8, 2022
cxMiguelSilva
cxMiguelSilva previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KICS Engine automation moved this from In progress to Pending code review Aug 8, 2022
joaoReigota1
joaoReigota1 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares merged commit a2b0fbc into master Aug 26, 2022
KICS Engine automation moved this from Pending code review to Done Aug 26, 2022
@rafaela-soares rafaela-soares deleted the fix/memory_consumption branch August 26, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoReigota1 joaoReigota1 joaoReigota1 approved these changes

@cxMiguelSilva cxMiguelSilva cxMiguelSilva left review comments

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx gabriel-cx is a code owner

Assignees

@rafaela-soares rafaela-soares

Labels
go Pull requests that update Go code
Projects
KICS Engine
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafaela-soares @joaoReigota1 @cxMiguelSilva