Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): change s3 bucket acl grants write acp security query #5780

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix(query): change s3 bucket acl grants write acp security query #5780

merged 2 commits into from
Sep 20, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Proposed Changes

  • change s3 bucket acl grants write acp security query for terraform
  • delete s3 bucket grants write acp security query for ansible

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature terraform Terraform query ansible Ansible query aws PR related with AWS Cloud labels Sep 9, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Sep 9, 2022
gabriel-cx
gabriel-cx approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rafaela-soares
rafaela-soares approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit 01a3bab into master Sep 20, 2022
@rafaela-soares rafaela-soares deleted the fix/s3_bucket_acl_grants_write_acp_permission branch September 20, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
ansible Ansible query aws PR related with AWS Cloud query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cxMiguelSilva @rafaela-soares @gabriel-cx