fix(query): terraform/aws/iam_access_key_is_exposed

[jycamier]

Closes #5845

Referring to AWS CIS Controls 1.12

Proposed Changes

• fix the query
• fix the tests

I submit this contribution under the Apache-2.0 license.

[cxMiguelSilva]

Hi @jycamier, thank you so much for your contribution!!
Regarding the changes to the Security Query, I think that indeed the approach is incorrect and your approach fixes it to the correct behavior.
I would like just to request some changes.

• Change the keyExpectedValue keyword from must to should in order to align the approach recently taken for all the new/changed Security Queries
• Change the query matadata.json descriptionText to IAM Access Key should not be active for root users
• If You feel comfortable updating the Ansible Security Query IAM Access Key Is Exposed to be aligned with the Terraform approach

[jycamier]

Hi @cxMiguelSilva

Change the keyExpectedValue keyword from must to should in order to align the approach recently taken for all the new/changed Security Queries

Done

Change the query matadata.json descriptionText to IAM Access Key should not be active for root users

Done

If You feel comfortable updating the Ansible Security Query IAM Access Key Is Exposed to be aligned with the Terraform approach

The rego, without any trouble.
The Ansible tests, not at all.

[cxMiguelSilva]

@jycamier thank you so much for your contribution.
Regarding the Ansible Security Query do not worry about it, we will address it.
The changes LGTM

[rafaela-soares]

LGTM 🚀

Thank you so much, @jycamier!