Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): improved regex to find AWS Access Key in assets/queries/terraform/aws/hardcoded_aws_access_key_in_lambda #5951

Merged
merged 2 commits into from
Oct 18, 2022
Merged

fix(query): improved regex to find AWS Access Key in assets/queries/terraform/aws/hardcoded_aws_access_key_in_lambda #5951

merged 2 commits into from
Oct 18, 2022

Conversation

rafaela-soares
Copy link
Contributor

Closes #5859

Proposed Changes

  • improved regex to find AWS Access Key in assets/queries/terraform/aws/hardcoded_aws_access_key_in_lambda

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added bug Something isn't working query New query feature terraform Terraform query aws PR related with AWS Cloud labels Oct 18, 2022
@rafaela-soares rafaela-soares added this to the bug milestone Oct 18, 2022
@rafaela-soares rafaela-soares self-assigned this Oct 18, 2022
@rafaela-soares rafaela-soares added this to In progress in KICS Queries via automation Oct 18, 2022
@rafaela-soares rafaela-soares mentioned this pull request Oct 18, 2022
Closed
cxMiguelSilva
cxMiguelSilva approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit ed46fa2 into master Oct 18, 2022
KICS Queries automation moved this from In progress to Done Oct 18, 2022
@cxMiguelSilva cxMiguelSilva deleted the fix_query_5859 branch October 18, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees

@rafaela-soares rafaela-soares

Labels
aws PR related with AWS Cloud bug Something isn't working query New query feature terraform Terraform query
Projects
KICS Queries
Done
Milestone
bug
Development

Successfully merging this pull request may close these issues.

query assets/queries/terraform/aws/hardcoded_aws_access_key_in_lambda trigger false positive
2 participants
@rafaela-soares @cxMiguelSilva