Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(query): fixed typos in query folder name and query name #5954

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

rafaela-soares
Copy link
Contributor

@rafaela-soares rafaela-soares commented Oct 19, 2022

Proposed Changes

  • assets/queries/terraform/alicloud/rds_instance_log_disconenctions_disabled to assets/queries/terraform/alicloud/rds_instance_log_disconnections_disabled
  • assets/queries/terraform/alicloud/rds_instance_tde_status_disable to assets/queries/terraform/alicloud/rds_instance_tde_status_disabled
  • Elasticsearch Log is disabled to Elasticsearch Log Disabled
  • assets/queries/terraform/azure/app_service_authentication_is_not_set to assets/queries/terraform/azure/app_service_authentication_disabled
  • assets/queries/terraform/azure/encryption_on_managed_disk_enabled to assets/queries/terraform/azure/encryption_on_managed_disk_disabled
  • assets/queries/terraform/azure/mssql_server_public_network_access_disabled to assets/queries/terraform/azure/mssql_server_public_network_access_enabled
  • assets/queries/terraform/kubernetes/container_host_ipc_is_true to assets/queries/terraform/kubernetes/shared_host_ipc_namespace
  • assets/queries/terraform/kubernetes/service_with_external_load_balance to
    assets/queries/terraform/kubernetes/service_with_external_load_balancer
  • assets/queries/k8s/service_with_external_load_balance to
    assets/queries/k8s/service_with_external_load_balancer
  • Service With External Load Balance to Service With External Load Balancer
  • assets/queries/googleDeploymentManager/sql_db_instance_backup_disable to assets/queries/googleDeploymentManager/sql_db_instance_backup_disabled

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added query New query feature terraform Terraform query labels Oct 19, 2022
@rafaela-soares rafaela-soares added this to the Documentation milestone Oct 19, 2022
@rafaela-soares rafaela-soares added this to In progress in KICS Queries via automation Oct 19, 2022
@rafaela-soares rafaela-soares self-assigned this Oct 19, 2022
@rafaela-soares rafaela-soares removed this from the Documentation milestone Oct 19, 2022
@Churro
Copy link
Contributor

Churro commented Oct 19, 2022

Hi @rafaela-soares, would be great if you could also correct assets/queries/k8s/service_with_external_load_balance 😊

@rafaela-soares
Copy link
Contributor Author

Hi @rafaela-soares, would be great if you could also correct assets/queries/k8s/service_with_external_load_balance 😊

Hi @Churro,

Yes, of course! Thank you so much for noticing! 🚀

Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit f6a2b9b into master Oct 24, 2022
@cxMiguelSilva cxMiguelSilva deleted the improve_query_folder_name branch October 24, 2022 15:44
KICS Queries automation moved this from In progress to Done Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query New query feature terraform Terraform query
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants