-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nifcloud): add nifcloud engine support #6314
feat(nifcloud): add nifcloud engine support #6314
Conversation
Hi @gabriel-cx , I created a PR with the content you suggested. |
Hi @gabriel-cx , Can you confirm the sentence above? |
Hi @tunakyonn , Sorry for the delay on your previous question! What do you think? |
58206c7
to
d8a4a3a
Compare
Hi @gabriel-cx , Thank you for your reply. |
Hi @tunakyonn , I updated your PR title and description to match our requirements, for now should be good, don't worry! :D In terms of the query itself, thank you very much! |
Hi @gabriel-cx , Thanks for your comment! |
Hi @tunakyonn |
Hi @gabriel-cx , Thanks for your comment!
However, if you write the following in query.rego, an error will occur during testing and it cannot be detected.
|
Hi @tunakyonn , No problem! In order to catch single network_interface or multiple network_interfaces try to have 2 policies in your rego file, like:
and
Where the first policy tries to find if there is more than one network_interfaces and the second tries to check if there is only one network_interface. Kindly tell us if this information was useful! |
Hi @gabriel-cx , Thanks for your advice! Also, I would like to ask, why can't I catch a single network_interface by writing something like the following?
|
Hi @tunakyonn , No problem! Thanks for the fix! Yeah, is a good question! When you have more than one network_interface the parser in the background detects that there is more than one item of that type and creates a list of them, and to 'catch' those we need to specify it as a list, like You can obtain the 'parser result' (internal JSON representation, e.g: the 2 images I sent previously) by checking the payload. And you can create/access the payload by running the -d (--payload-path) KICS flag. Hope this information clarifies your doubts! |
Hi @gabriel-cx , Thank you for your comment! My fix is complete, but I still have go-ci-integration and go-e2e errors. |
Hi @tunakyonn , We are checking what can be the issue and we will notify you if you need to do some changes. |
Hi @tunakyonn , Looks like you need to add "nifcloud" here! :D |
44bdd8f
to
f482d93
Compare
Hi @gabriel-cx , Thank you for your advice! |
@tunakyonn looks like everything is green now, thanks!! |
Hi @tunakyonn , We plan to merge this PR and make it available in the next KICS version (1.7.9). |
Hi @gabriel-cx , Thank you for contacting! Is it okay to create the second pull request that was discussed in the link below after this pull request is merged? |
Hi @tunakyonn , Sure! Feel free to create a new PR with new nifcloud queries! We'd love to see that new PR! |
@tunakyonn if you prefer, you can create now the new PR with new branch based on this current branch. So, like that we can review both and merge the 2 when everything looks good! Steps that we recommend:
That way we can merge this current PR first and then the new one |
Hi @tunakyonn , Hope this message finds you well! I'm happy to announce that soon we will be able to merge your PR! :D Thank you again!! |
Hi @gabriel-cx , Sorry for the late confirmation. I understand about the logo. |
Hi @tunakyonn , No problem! The logo is not a mandatory thing. In case you can't add the logo for some reason, tell us and we can support you on that if needed. |
Hi @gabriel-cx , Thank you for your kind communication. |
Hi @tunakyonn , Thank you for your information. No problem, in the end, if you can't add the logo we can provide it from our side. Currently, we changed the way we want to approach the "Beta features". This means, we are waiting this PR to be merged so we can merge yours as well. I will keep you updated! |
Hi @gabriel-cx , Thank you for your kind communication! I also understand about PR. |
Hi @tunakyonn , Thank you for your inputs. The only changes we'd like to ask you is, kindly add "experimental": "true" in every metadata.json files of every query (in this PR you just have one query so you just need to change one metadata file). KICS will have a new flag And I also noticed that you have some conflicts in your PR, if you need our support to tackle it, just ping me! |
…_has_common_private query
d848763
to
e001464
Compare
Hi @gabriel-cx , Thank you for contacting me. |
@tunakyonn thank you! It's merged! :D |
Proposed Changes
I submit this contribution under the Apache-2.0 license.