Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Engine) - Fix resolver panic #6519

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Fix(Engine) - Fix resolver panic #6519

merged 7 commits into from
Jul 18, 2023

Conversation

pereiramarco011
Copy link
Contributor

Closes #6513

Proposed Changes

  • Fix condition being checked positively for errors and returning a panic
  • Added e2e test

I submit this contribution under the Apache-2.0 license.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

@asofsilva asofsilva merged commit 49516d7 into master Jul 18, 2023
13 checks passed
@asofsilva asofsilva deleted the kics/891 branch July 18, 2023 12:18
@Porkepix Porkepix mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KICS 1.7.3 is throwing exception panic: interface conversion: interface {} is string, not yaml.Node
3 participants
@pereiramarco011 @cxMiguelSilva @asofsilva