Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(panic): add panic handler to possible panic places #6527

Merged
merged 14 commits into from
Aug 29, 2023
Merged

Conversation

pereiramarco011
Copy link
Contributor

@pereiramarco011 pereiramarco011 commented Jul 19, 2023

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@pereiramarco011 pereiramarco011 marked this pull request as draft July 19, 2023 16:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

kics-logo

KICS version: v1.7.4

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@kaplanlior
Copy link
Contributor

@liorj-orca, I would appreciate your feedback on this PR.
CC @lior-orca

@lior-orca
Copy link

@pereiramarco011 besides maybe having a common helper method to build and print the error, the change looks good and important.
I suggest pushing it forward, in order to increase the resiliency.
We can always add more support to other uncovered areas

@liorj-orca
Copy link
Contributor

liorj-orca commented Aug 15, 2023

@pereiramarco011 overall looks good. As @lior-orca stated, I think we can push the fix as is and add more cases later on along the way.
One more case that you can think wether or not we want to avoid the error:

  • Getsources function (
    getterDst, err := getPaths(&goGetter)
    ) could fail for several reasons, among other thing a bug of go-getter. what about skipping any path that we fail to resolve?

@pereiramarco011 pereiramarco011 marked this pull request as ready for review August 17, 2023 12:12
@pereiramarco011 pereiramarco011 changed the title possible panic handling places feat(panic): add panic handler to possible panic places Aug 17, 2023
@lior-orca
Copy link

@pereiramarco011 any updates? what is preventing us from pushing the change?

@pereiramarco011
Copy link
Contributor Author

pereiramarco011 commented Aug 24, 2023

@pereiramarco011 any updates? what is preventing us from pushing the change?

Hello Lior, I hope all is well.

The development is complete, all that is left to do is the review and QA, it is programmed to be delivered with KICS version 1.7.7, should be out in less than a week if all goes well.

Thank you for all the help,

Best Regards,
Marco from KICS Team

gabriel-cx
gabriel-cx previously approved these changes Aug 25, 2023
gabriel-cx
gabriel-cx previously approved these changes Aug 29, 2023
@gabriel-cx gabriel-cx merged commit 471beea into master Aug 29, 2023
17 checks passed
@gabriel-cx gabriel-cx deleted the kics/906 branch August 29, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants