-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): support GCP IAM policy members as lists #6548
fix(query): support GCP IAM policy members as lists #6548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tohar-orca, thank you so much for this amazing contribution.
The proposed changes LGTM 🚀
Hi @asofsilva, kindly do the QA checking for these changes. |
"issueType": "IncorrectValue", | ||
"keyExpectedValue": sprintf("google_iam_policy[%s].binding[%s].role should not have admin, editor, owner, or write privileges for service account member", [name, format_int(x, 10)]), | ||
"keyActualValue": sprintf("google_iam_policy[%s].binding[%s].role has admin, editor, owner, or write privilege for service account member", [name, format_int(x, 10)]), | ||
"searchLine": common_lib.build_search_line(["resource", "google_iam_policy", name, "binding", x, "role"], []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"searchLine": common_lib.build_search_line(["resource", "google_iam_policy", name, "binding", x, "role"], []), | |
"searchLine": common_lib.build_search_line(["data", "google_iam_policy", name, "binding", x, "role"], []), |
Hi @Tohar-orca, @asofsilva noticed that the line is not correctly detected during the QA checks. Would you mind changing the search lines for the Policies that check the data
from resource
to data
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! Done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Hi @Tohar-orca,
What do you think? Thank you :) |
…icy-members-as-list
…ohar-orca/kics into support-gcp-iam-policy-members-as-list
Hey @asofsilva good idea, I've added a test as you suggested :) |
Proposed Changes
I submit this contribution under the Apache-2.0 license.