Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): countLines, IgnoreLines and fileCommands #6611

Merged
merged 41 commits into from
Feb 21, 2024
Merged

fix(query): countLines, IgnoreLines and fileCommands #6611

merged 41 commits into from
Feb 21, 2024

Conversation

cx-henriqueAlvelos
Copy link
Contributor

@cx-henriqueAlvelos cx-henriqueAlvelos commented Aug 5, 2023 •
edited

Closes #6599

Proposed Changes

  • Countlines for Helm (counting with the original file, removing KICS properties)
  • Countlines for other filetypes (counting with the original file)
  • IgnoreLines (counting with the original file)
  • FileCommands for resolved files
  • Tests

I submit this contribution under the Apache-2.0 license.

@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023 •
edited

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@cx-henriqueAlvelos cx-henriqueAlvelos linked an issue Aug 5, 2023 that may be closed by this pull request
Ignore is not working correctly on YAML files #6599
Closed
@cx-henriqueAlvelos cx-henriqueAlvelos changed the title fix(Sink): countLines, IgnoreLines and fileCommands fixed fix(sink): countLines, IgnoreLines and fileCommands fixed Aug 5, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos changed the title fix(sink): countLines, IgnoreLines and fileCommands fixed fix(sink): countLines, IgnoreLines and fileCommands Aug 8, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos linked an issue Aug 8, 2023 that may be closed by this pull request
Incorrect line numbers and missing line content when scanning Helm charts #6377
Closed
@cx-henriqueAlvelos cx-henriqueAlvelos linked an issue Aug 9, 2023 that may be closed by this pull request
"kics-scan ignore" doesn't work as expected #6458
Closed
cxMiguelSilva
cxMiguelSilva previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeng
Copy link

@gabriel-cx @pereiramarco011 could you take a look into this once you have time please?

@cx-henriqueAlvelos cx-henriqueAlvelos changed the title fix(sink): countLines, IgnoreLines and fileCommands fix(query): countLines, IgnoreLines and fileCommands Sep 11, 2023
@github-actions github-actions bot added the query New query feature label Sep 11, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos changed the title fix(query): countLines, IgnoreLines and fileCommands fix(query): countLines, IgnoreLines and fileCommands Sep 11, 2023
@github-actions github-actions bot added the community Community contribution label Oct 18, 2023
cxMiguelSilva
cxMiguelSilva approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@asofsilva asofsilva merged commit 430830c into master Feb 21, 2024
20 checks passed
@asofsilva asofsilva deleted the kics-987 branch February 21, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx gabriel-cx is a code owner

@pereiramarco011 pereiramarco011 Awaiting requested review from pereiramarco011

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
community Community contribution query New query feature
Projects
None yet
Milestone
No milestone
6 participants
@cx-henriqueAlvelos @felipeng @cxMiguelSilva @asofsilva @gabriel-cx @JoaoCxMartins