Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): skip broken symlink/eloop #6665

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

liorj-orca
Copy link
Contributor

@liorj-orca liorj-orca commented Aug 22, 2023

Closes #
#6413
#6659

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the community Community contribution label Aug 22, 2023
@liorj-orca liorj-orca changed the title fix(engine): skip broken synlink/eloop fix(engine): skip broken symlink/eloop Aug 22, 2023
@liorj-orca liorj-orca force-pushed the broken_symlink branch 2 times, most recently from 3921fcb to 98b7cf4 Compare August 22, 2023 13:24
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe you can add an e2e test, but other than that looks great.

Thanks

gabriel-cx
gabriel-cx previously approved these changes Aug 28, 2023
@gabriel-cx
Copy link
Collaborator

Hi @liorj-orca ,

It's possible for you to add the e2e test?

@gabriel-cx gabriel-cx merged commit e3f8f15 into Checkmarx:master Aug 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants