Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): ca certificate identifier is outdated tf aws #6683

Merged
merged 7 commits into from
Sep 5, 2023
Merged

fix(query): ca certificate identifier is outdated tf aws #6683

merged 7 commits into from
Sep 5, 2023

Conversation

freitasmillena
Copy link
Contributor

Closes #6680

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added query New query feature terraform Terraform query aws PR related with AWS Cloud labels Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.6

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

cx-henriqueAlvelos

This comment was marked as outdated.

Sign in to view

cx-henriqueAlvelos
cx-henriqueAlvelos suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@cx-henriqueAlvelos cx-henriqueAlvelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good to me. However, descriptionText should be updated also

pereiramarco011
pereiramarco011 previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

What do you think of changing the descriptionUrl to the one added in the DescriptionText? it doesn't seem good to have 2 urls, I want to know your opinion on it 😄

pereiramarco011
pereiramarco011 previously approved these changes Sep 5, 2023
View reviewed changes
@gabriel-cx gabriel-cx merged commit bc0b22c into master Sep 5, 2023
19 checks passed
@gabriel-cx gabriel-cx deleted the fix_6680 branch September 5, 2023 14:48
@chenrui333 chenrui333 mentioned this pull request Sep 14, 2023
Merged
@fablocke fablocke mentioned this pull request Oct 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-henriqueAlvelos cx-henriqueAlvelos cx-henriqueAlvelos approved these changes

@pereiramarco011 pereiramarco011 pereiramarco011 left review comments

Assignees
No one assigned
Labels
aws PR related with AWS Cloud query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query(terraform): ca_certificate_identifier_is_outdated
4 participants
@freitasmillena @pereiramarco011 @cx-henriqueAlvelos @gabriel-cx