Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(converter): improve check dynamic known types #6815

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

liorj-orca
Copy link
Contributor

@liorj-orca liorj-orca commented Nov 23, 2023

This PR improves the case where the resource/block needs some recursive handling.
without this case(an example was added to the UT), we will get an error such as:
"Error: failed to read sources: failed to save file content: json: error calling MarshalJSON for type model.Document: value is not known
"

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the community Community contribution label Nov 23, 2023
@liorj-orca liorj-orca changed the title Improve check dynamic known types fix(converter): improve check dynamic known types Nov 23, 2023
@kaplanlior kaplanlior added the enhancement Enhancement label Dec 4, 2023
@gabriel-cx
Copy link
Collaborator

Hi @liorj-orca ,

Thank you for this PR!
It's possible for you to provide us the example file? So we can check from our side. Thanks in advance.

@asofsilva asofsilva merged commit f57c4a6 into Checkmarx:master Dec 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants