Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scanner): parallel scanning #6833

Merged
merged 19 commits into from
Feb 26, 2024
Merged

Conversation

liorj-orca
Copy link
Contributor

@liorj-orca liorj-orca commented Dec 19, 2023

Closes #6583

Allowing end-users to control the level of parallelism they would like to use as part of their scan.
By default, the new flag would be "disabled" as there will be only one worker.
In case the user would like to auto-detect parallelism - we would set the number of workers according to GONUMPROCS.

some future job that can be done around this, is trying to run the analyzing of files(where we decide which files to scan and of which type) in the same way.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added community Community contribution feature request Community: new feature request labels Dec 19, 2023
@gabriel-cx
Copy link
Collaborator

Hi @liorj-orca ,

Sorry for the late reply and thank you very much for this amazing contribution!
We are reviewing and testing this PR. Kindly resolve the conflicts.

We plan to give you more feedback during this week.

@pereiramarco011
Copy link
Contributor

Hello @liorj-orca

In the name of the KICS Team I would like to thank you very much for this contribution, after some consideration we decided to move forward with this PR, we see only 4 things that need to be done and intend on doing it on our side before passing the pr to QA.

Creation of 3 e2e tests (covering the cases of self detect, sequential, and user inputted)
Addition of a max value to the number of go routines from the flag
Changing the default value of the flag to 0
Fixing conflicts

As soon as this is ready it will be passed to QA and it should be merged. 🚀 💪

Best Regards,

KICS Team

@asofsilva asofsilva merged commit b6b88d7 into Checkmarx:master Feb 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent Queries Scan
4 participants