Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(results): update cyclonedx reports to support v1.5 #6841

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Dec 29, 2023

Closes: #6827

Proposed Changes
-update cyclonedx reports to support v.1.5 from v.1.3

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the feature New feature label Dec 29, 2023
Copy link
Contributor

kics-logo

KICS version: v1.7.11

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

kaplanlior
kaplanlior previously approved these changes Jan 1, 2024
@kaplanlior
Copy link
Member

The change looks minimal & clean. Thanks.

Do we need to change anything in the report itself in addition the schema reference?

For example - v1.5 support critical severity
https://cyclonedx.org/docs/1.5/xml/#type_severityType

var cycloneDxSeverityLevelEquivalence = map[model.Severity]string{
"INFO": "None",
"LOW": "Low",
"MEDIUM": "Medium",
"HIGH": "High",
}

Copy link
Collaborator

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also update the Documentation here to make sure it references the new current version being used instead of the old one

Other than that looks good to me

@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Jan 10, 2024
@asofsilva asofsilva merged commit 8613564 into master Jan 17, 2024
17 checks passed
@asofsilva asofsilva deleted the cyclonedx branch January 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(results): update to support cyclonedx bom schema 1.5
5 participants