feat(cwe): add cwe into sarif report and KICS CLI results #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KICS version: v1.7.11
|
JoaoCxMartins
requested changes
Jan 8, 2024
JoaoCxMartins
previously approved these changes
Jan 9, 2024
gabriel-cx
reviewed
Jan 9, 2024
pkg/report/model/sarif.go
Outdated
| @@ -43,6 +43,7 @@ type ruleCISMetadata struct { | |||
| type sarifMessage struct { | |||
| Text string `json:"text"` | |||
| MessageProperties sarifProperties `json:"properties,omitempty"` | |||
| CWE string `json:"cwe,omitempty"` | |||
There was a problem hiding this comment.
do we really need this item?
gabriel-cx
previously approved these changes
Jan 9, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabriel-cx
requested changes
Jan 26, 2024
Dockerfile
Outdated
| @@ -66,6 +66,7 @@ RUN wget https://github.com/GoogleCloudPlatform/terraformer/releases/download/0. | |||
| # kics-scan ignore-line | |||
| COPY --from=build_env /app/bin/kics /app/bin/kics | |||
| COPY --from=build_env /app/assets/queries /app/bin/assets/queries | |||
| COPY --from=build_env /app/assets/cwe_csv/* /app/bin/assets/cwe_csv | |||
There was a problem hiding this comment.
kindly perform this same update into this dockerfiles if needed
|
Relates to: #6373 |
JoaoCxMartins
previously approved these changes
Jan 29, 2024
cxMiguelSilva
previously approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Awesome work @ArturRibeiro-CX 🙌
Just make sure the dockerfiles work as expected for the ones not tested in workflows as @gabriel-cx mentioned.
ArturRibeiro-CX
dismissed stale reviews from cxMiguelSilva and JoaoCxMartins
via
646f5a5
gabriel-cx
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I submit this contribution under the Apache-2.0 license.