Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): improve similarity id #6851

Merged
merged 19 commits into from
Jan 18, 2024
Merged

feat(engine): improve similarity id #6851

merged 19 commits into from
Jan 18, 2024

Conversation

JoaoCxMartins
Copy link
Collaborator

Closes #

Proposed Changes

  • change the logic of similarity id, when the file is minified, in this case instead of the line we should use the search key

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the feature New feature label Jan 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v1.7.11

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

cxMiguelSilva
cxMiguelSilva requested changes Jan 16, 2024
View reviewed changes
stuck.json Outdated Show resolved Hide resolved
cxMiguelSilva
cxMiguelSilva previously approved these changes Jan 17, 2024
View reviewed changes
@asofsilva asofsilva merged commit 70d1949 into master Jan 18, 2024
17 checks passed
@asofsilva asofsilva deleted the joaom/kics-1276 branch January 18, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoaoCxMartins @cxMiguelSilva @asofsilva