Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): improve query Key Vault Not Recoverable #6862

Merged
merged 4 commits into from
Feb 6, 2024
Merged

fix(query): improve query Key Vault Not Recoverable #6862

merged 4 commits into from
Feb 6, 2024

Conversation

JoaoCxMartins
Copy link
Collaborator

Closes #

Proposed Changes

  • add search value to query Key Vault Not Recoverable, lead with similarity id

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@JoaoCxMartins JoaoCxMartins changed the title fix(query): Key Vault Not Recoverable fix(query): improve query Key Vault Not Recoverable Jan 30, 2024
cxMiguelSilva
cxMiguelSilva previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pereiramarco011
pereiramarco011 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@asofsilva asofsilva merged commit 0d07994 into master Feb 6, 2024
21 checks passed
@asofsilva asofsilva deleted the joaom/kics-1293 branch February 6, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereiramarco011 pereiramarco011 pereiramarco011 approved these changes

@cxMiguelSilva cxMiguelSilva cxMiguelSilva left review comments

Assignees
No one assigned
Labels
query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoaoCxMartins @cxMiguelSilva @pereiramarco011 @asofsilva