Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): deprecate query Container Requests Not Equal To It's Limits #6890

Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix(query): deprecate query Container Requests Not Equal To It's Limits #6890

merged 4 commits into from
Mar 20, 2024

Conversation

JoaoCxMartins
Copy link
Collaborator

@JoaoCxMartins JoaoCxMartins commented Feb 19, 2024 •
edited

Closes #

Proposed Changes

  • deprecate query Container Requests Not Equal To It's Limits, because there is duplicated logic with these queries Container Memory Requests Not Equal To Its Limits, Container CPU Requests Not Equal To Its Limits, Memory Requests Not Defined, Memory Limits Not Defined, CPU Requests Not Set, and CPU Limits Not Set

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

cxMiguelSilva
cxMiguelSilva previously approved these changes Feb 19, 2024
View reviewed changes
@JoaoCxMartins
Merge branch 'master' into joaom/kics-1218-delete
7867ea7 
# Conflicts:
#	docs/queries/all-queries.md
#	docs/queries/kubernetes-queries.md
@JoaoCxMartins
remove
e2ca696
@asofsilva asofsilva merged commit a69d801 into master Mar 20, 2024
23 checks passed
@asofsilva asofsilva deleted the joaom/kics-1218-delete branch March 20, 2024 10:07
@BrewTestBot BrewTestBot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees
No one assigned
Labels
query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoaoCxMartins @cxMiguelSilva @asofsilva