Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analyzer): gitignore only being used to exclude files from the project itself #6896

Merged
merged 11 commits into from
Feb 29, 2024
Merged

fix(analyzer): gitignore only being used to exclude files from the project itself #6896

merged 11 commits into from
Feb 29, 2024

Conversation

JulioSCX
Copy link
Contributor

Proposed Changes

  • gitignore file is now only used to exclude files from the project itself, not its full path

I submit this contribution under the Apache-2.0 license.

@JulioSCX JulioSCX changed the title fix(engine): gitignore only being used to exclude files from the project itself fix(analyzer): gitignore only being used to exclude files from the project itself Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

pereiramarco011
pereiramarco011 requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to create an e2e test where the user scenario is replicated to be sure it keeps working?

small comment other than that LGTM 😄

pkg/analyzer/analyzer.go Outdated Show resolved Hide resolved
@asofsilva asofsilva merged commit bd90606 into master Feb 29, 2024
20 checks passed
@asofsilva asofsilva deleted the kics-1329 branch February 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereiramarco011 pereiramarco011 pereiramarco011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JulioSCX @pereiramarco011 @asofsilva