Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): improve query platform_flag_with_from #6955

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Conversation

JoaoCxMartins
Copy link
Collaborator

Closes #

Proposed Changes

  • improve query platform_flag_with_from

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label Mar 18, 2024
Copy link
Contributor

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@asofsilva asofsilva merged commit 812327b into master Mar 20, 2024
22 checks passed
@asofsilva asofsilva deleted the joaom/kics-1379 branch March 20, 2024 16:03
@lior-orca
Copy link

lior-orca commented May 1, 2024

@JoaoCxMartins this PR accidentally changed the meaning of the rule...

--platform SHOULD NOT be used...

Reference - https://github.com/hadolint/hadolint/wiki/DL3029

cc @kaplanlior

@lior-orca
Copy link

@cxMiguelSilva I see you approved it, can you give it a second look?

@JoaoCxMartins
Copy link
Collaborator Author

Hi @lior-orca
how are you?
About this query, and its behavior and description.
Last Tuesday was merged this PR, #7031 , to make the behavior congruent with the description.
About the behavior changes, this change came from internal appsec research.
Would you change anything?

@lior-orca
Copy link

@JoaoCxMartins please see the reference to hadolint

I still believe the rule was wrongly changed it's meaning

@gabriel-cx
Copy link
Collaborator

Hi @lior-orca ,

Thx for the info. We will revert those changes, and they will be available in the next KICS version, v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants