Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kics): fix max file size using directories in check KICS-0000 #6967

Merged
merged 23 commits into from
Apr 15, 2024
Merged

fix(kics): fix max file size using directories in check KICS-0000 #6967

merged 23 commits into from
Apr 15, 2024

Conversation

pereiramarco011
Copy link
Collaborator

@pereiramarco011 pereiramarco011 commented Mar 21, 2024 •
edited by JoaoCxMartins

Proposed Changes

  • skip directories being checked in max file size check
  • add unit test
  • add e2e

I submit this contribution under the Apache-2.0 license.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@JoaoCxMartins JoaoCxMartins changed the title fix(kics): fix max file size using directories in check fix(kics): fix max file size using directories in check KICS-0000 Apr 12, 2024
@asofsilva asofsilva merged commit 1275dcd into master Apr 15, 2024
21 checks passed
@asofsilva asofsilva deleted the fix-max-file-size branch April 15, 2024 15:42
@BrewTestBot BrewTestBot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pereiramarco011 @cxMiguelSilva @asofsilva @JoaoCxMartins @gabriel-cx