Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): vcp peering route table should restrict cidr query with fp results #7067

Merged
merged 6 commits into from
May 23, 2024
Merged

fix(query): vcp peering route table should restrict cidr query with fp results #7067

merged 6 commits into from
May 23, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented May 21, 2024 •
edited
Loading

Closes #6973

Proposed Changes

  • Fix false positives for aws_route_table resources with more than one route;
  • Fix search_Line to correctly output the route line with vulnerabilities;
  • Fix expected and actual results with correct naming of the resource with vulnerabilities;

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX self-assigned this May 21, 2024
@github-actions github-actions bot added query New query feature aws PR related with AWS Cloud labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX changed the title fix(query): VPC Peering Route Table should restrict CIDR query with FP results fix(query): vcp peering route table should restrict cidr query with fp results May 21, 2024
@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review May 22, 2024 08:47
EduardoSemanas
EduardoSemanas approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-andrep cx-andrep merged commit 1d1d835 into master May 23, 2024
26 checks passed
@cx-andrep cx-andrep deleted the AST-43001 branch May 23, 2024 16:14
@BrewTestBot BrewTestBot mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoSemanas EduardoSemanas EduardoSemanas approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva

@JoaoCxMartins JoaoCxMartins Awaiting requested review from JoaoCxMartins

@cx-ruiaraujo cx-ruiaraujo Awaiting requested review from cx-ruiaraujo

@asofsilva asofsilva Awaiting requested review from asofsilva

@cx-andrep cx-andrep Awaiting requested review from cx-andrep

Assignees

@ArturRibeiro-CX ArturRibeiro-CX

Labels
aws PR related with AWS Cloud query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(aws): vpc peering route table with unrestricted cidr false-positive
3 participants
@ArturRibeiro-CX @EduardoSemanas @cx-andrep