Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update host.py #1

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Update host.py #1

merged 3 commits into from
Feb 14, 2022

Conversation

shock0572
Copy link
Contributor

Added the possibility to use an ip_address when adding a host

Added the possibility to use an ip_address when adding a host
Added multisite options, formatted host ip when it's not local
Edited for multisite
@robin-checkmk robin-checkmk merged commit 35c0749 into Checkmk:devel Feb 14, 2022
@robin-checkmk
Copy link
Member

Hi @shock0572 and thank you for your contribution!
I merged it for now, but there will be some additional changes necessary, regarding documentation and possibly some naming. Just for your awareness, so you can keep an eye on the updates to come.

@shock0572
Copy link
Contributor Author

shock0572 commented Feb 14, 2022

Of course, my code was merely a hack!
Thank you for the merge though, I will take a look here, when all is updated

@shock0572 shock0572 deleted the patch-2 branch February 14, 2022 17:23
@robin-checkmk
Copy link
Member

Quick follow up: @lgetwan reworked the host module and created a proper implementation of host attributes in c4cbf3a. Just for your awareness @shock0572.

@shock0572
Copy link
Contributor Author

thank you!

robin-checkmk pushed a commit that referenced this pull request Nov 18, 2022
robin-checkmk pushed a commit that referenced this pull request May 22, 2023
* Update host.py

Added the possibility to use an ip_address when adding a host
Added multisite options, formatted host ip when it's not local
robin-checkmk pushed a commit that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants