Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better rule arguments parsing and default values #231

Closed
wants to merge 1,070 commits into from
Closed

Better rule arguments parsing and default values #231

wants to merge 1,070 commits into from

Conversation

geof77
Copy link
Contributor

@geof77 geof77 commented Jan 17, 2023 •
edited
Loading

This PR improves arguments checking and documentation:

  • detailed documentation for all supported parameters
  • update the examples and their syntax
  • apply default values so the user can omit conditions and properties suboptions or even entirely
  • validate the format of folder and documentation_url
  • enforce complete expressions for host_name, host_tags, host_labels and service_labels
  • take care of parameters with empty values causing API errors

Related issues: #181 #182

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

robin-checkmk and others added 30 commits November 18, 2022 13:48
@robin-checkmk
Fix linting findings.
ca5c95c
@robin-checkmk
Fix module args.
3aedfab
@robin-checkmk
Merge pull request Checkmk#168 from msekania/feature-contacts-groups
33b00fe 
Feature contacts groups
@robin-checkmk
Prepare release.
23e3207
@robin-checkmk
Merge pull request Checkmk#190 from tribe29/fix_188_key_error
742ef89 
Fix Checkmk#188: Better readable API error in Downtime module.
@robin-checkmk
Merge pull request Checkmk#184 from tribe29/feature-move-doc-validate…
ee8e40f 
…-certs

Clean up documentation and wording
@robin-checkmk
Merge branches 'devel' and 'devel' of github.com:tribe29/ansible-coll…
00fedd1 
…ection-tribe29.checkmk into devel
@robin-checkmk
Add and update changelogs.
02262f7
@robin-checkmk
Bugfix contact_group module.
980c910
@robin-checkmk
Merge pull request Checkmk#177 from tribe29/devel
8e07939 
Release 0.12.0
Update Docs and Changelogs
59dbb5d
@robin-checkmk
Merge pull request Checkmk#193 from tribe29/changelogs-docs-update-devel
e4c553d 
[Auto] Update changelogs and docs
@robin-checkmk
Merge pull request Checkmk#194 from tribe29/devel
7b6edde 
Changelogs and Docs
@robin-checkmk
Merge branch 'devel' into update-feature-host-groups
487eb10
@robin-checkmk
Merge branch 'devel' into feature-service-groups
dca860a
@robin-checkmk
Bump Checkmk versions in molecule tests.
6c229ba
@robin-checkmk
Bump Checkmk versions in integration tests.
52ea1ef
@robin-checkmk
Bump Checkmk version in rule integration test.
cc0b2e1
@robin-checkmk
Merge pull request Checkmk#197 from tribe29/feature-update-tests-chec…
efae305 
…kmk-version

Update Checkmk versions in tests
@robin-checkmk
Bump default Checkmk version.
9754c4a
@robin-checkmk
Add support for new password hashing.
11c0c7e
@robin-checkmk
Merge pull request Checkmk#199 from tribe29/feature-new-pass-hashing
ed00484 
Add support for new password hashing algorithm to agent role
@robin-checkmk
Revert "Add support for new password hashing algorithm to agent role"
f0893df
@robin-checkmk
Merge pull request Checkmk#200 from tribe29/revert-199-feature-new-pa…
9744617 
…ss-hashing

Revert "Add support for new password hashing algorithm to agent role"
@robin-checkmk
Merge pull request Checkmk#201 from tribe29/feature-new-pass-hashing
486d8a6 
Add support for new password hashing algorithm to agent role
@robin-checkmk
Merge pull request Checkmk#178 from msekania/feature-service-groups
52e3cc3 
Feature service groups
@robin-checkmk
Update hosts and Vagrantfile.
0460afe
@robin-checkmk
Add compatibility matrix.
efb0e32
@robin-checkmk
Fix integration tests Checkmk versions.
02e6e13
@robin-checkmk
Prepare release.
3cdc04e
robin-checkmk and others added 17 commits February 3, 2023 10:55
@robin-checkmk
Merge pull request Checkmk#248 from thorian93/fix-discovery-become
31b6956 
Fix become for service discovery in agent role
@robin-checkmk
Bump Checkmk versions in tests.
2f31f16
@robin-checkmk
Test update of release action.
64b89eb 
According to https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.
@robin-checkmk
Fix release action.
3f1599b
@robin-checkmk
Clean up after fixes and remove duplicate task.
47138d4
@robin-checkmk
Merge pull request Checkmk#244 from tribe29/fix-243-module-downtimes
9001680 
module downtimes: better parameter handling
@robin-checkmk
Re-enable all tasks after successful tests.
e8d68b7
@robin-checkmk
Merge branch 'devel' of github.com:tribe29/ansible-collection-tribe29…
dbfa520 
….checkmk into devel
@robin-checkmk
Merge pull request Checkmk#253 from tribe29/feature-update-release-ac…
7eb728b 
…tion

Update release action with current syntax
@robin-checkmk
Update Python versions.
3abe06f
@robin-checkmk
Prepare release 0.16.2.
4ff800a
@robin-checkmk
Merge branch 'devel' of github.com:tribe29/ansible-collection-tribe29…
9f15f05 
….checkmk into devel
Update Docs and Changelogs
15aa570
@robin-checkmk
Merge pull request Checkmk#255 from tribe29/changelogs-docs-update-devel
e486e9b 
[Auto] Update changelogs and docs
@lgetwan
Merge pull request Checkmk#241 from geof77/rule-safe-eval
4178145 
Use safe_eval instead of temporary rules for comparison
@tonk @robin-checkmk
Added configuration setting for force_foreign_changes (Checkmk#242)
211fe2e 
* Added configuration setting for force_foreign_changes

---------

Co-authored-by: Robin Gierse <93658105+robin-tribe29@users.noreply.github.com>
@geof77
Merge branch 'devel' into fix-rules-args-parsing
8e1b844
@github-actions
Copy link

This pull request has been stale for 60 days. It will close in 7 days.

@github-actions github-actions bot added the stale Stale issues and pull requests. label Apr 11, 2023
@lgetwan
Copy link
Contributor

lgetwan commented Apr 13, 2023

@geof77 Is this PR still a draft?

@geof77
Copy link
Contributor Author

geof77 commented Apr 13, 2023

@lgetwan : yes, I would need help testing it thouroughly and it certainly needs a bit of polish...

@github-actions github-actions bot removed the stale Stale issues and pull requests. label Apr 14, 2023
@lgetwan
Copy link
Contributor

lgetwan commented Apr 14, 2023

Two weeks ahead, I have some gaps in my calendar. I hope I can have a look at this, then.

@robin-checkmk robin-checkmk added the release:0.22.0 Affects the mentioned release. label Apr 14, 2023
@robin-checkmk robin-checkmk removed the release:0.22.0 Affects the mentioned release. label May 12, 2023
@robin-checkmk
Copy link
Member

@geof77 could you take a look at the conflicts and fix them? Thanks!

@github-actions
Copy link

This pull request has been stale for 60 days. It will close in 7 days.

@github-actions github-actions bot added the stale Stale issues and pull requests. label Jul 22, 2023
@github-actions github-actions bot closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgetwan lgetwan Awaiting requested review from lgetwan lgetwan is a code owner

@robin-checkmk robin-checkmk Awaiting requested review from robin-checkmk robin-checkmk will be requested when the pull request is marked ready for review robin-checkmk is a code owner

Assignees

@lgetwan lgetwan

Labels
enhancement New feature or request module:rule This affects the rule module stale Stale issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@geof77 @lgetwan @robin-checkmk @flybyray @msekania @nico-checkmk @tonk @thorian93