Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic molecule tests for agent role #323

Merged
merged 11 commits into from
May 4, 2023

Conversation

robin-checkmk
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are no molecule tests for the agent role.

What is the new behavior?

Very basic tests have been implemented. Currently, only the installation itself is verified, but that will be extended in the future.

Other information

@robin-checkmk robin-checkmk added enhancement New feature or request role:agent This affects the agent role labels Apr 20, 2023
@robin-checkmk robin-checkmk self-assigned this Apr 20, 2023
@robin-checkmk
Copy link
Member Author

The molecule tests fail at all Python versions other than 3.8. However, server molecule tests run just fine and they are literally the same. I smell a flake here, so will let this cook for some days. Maybe it resolves on its own.

Hints are very welcome, if you spot a problem. 👀

@robin-checkmk robin-checkmk linked an issue Apr 21, 2023 that may be closed by this pull request
@robin-checkmk
Copy link
Member Author

@robin-checkmk
Copy link
Member Author

With molecule 5.0.1 the issues mentioned above seem fixed, or at least operational.
I removed the -lint scenario - also for the server role - as that is obsolete starting with molecule 5.0.0.

With these changes, the PR is ripe to be merged.

@robin-checkmk robin-checkmk mentioned this pull request May 4, 2023
7 tasks
@robin-checkmk robin-checkmk added the release:0.21.0 Affects the mentioned release. label May 4, 2023
@robin-checkmk robin-checkmk merged commit 98946ab into devel May 4, 2023
32 checks passed
@robin-checkmk robin-checkmk deleted the feature-agent-molecule branch May 4, 2023 13:18
robin-checkmk added a commit that referenced this pull request May 22, 2023
Enable basic molecule tests for agent role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release:0.21.0 Affects the mentioned release. role:agent This affects the agent role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEED] Integration Tests Rework
1 participant