Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.23.0 #340

Merged
merged 1,427 commits into from
Jun 7, 2023
Merged

Release 0.23.0 #340

merged 1,427 commits into from
Jun 7, 2023

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented May 15, 2023 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: e.g. #1

What is the new behavior?

Other information

robin-checkmk and others added 30 commits March 14, 2023 11:11
@robin-checkmk
Merge pull request #285 from tribe29/devel
f92c419 
Update changelogs and docs
@sscmh
added comment
af51b8b
@sscmh
Merge branch 'main' of https://github.com/sscmh/ansible-collection-tr…
aad5ef6 
…ibe29.checkmk
@robin-checkmk
Update Vagrantfile.
37cfa9a
@robin-checkmk
Bump Checkmk version.
17b07ac
@robin-checkmk
Merge branch 'devel' of github.com:tribe29/ansible-collection-tribe29…
d2a0114 
….checkmk into feature-extend-demo-playbooks
@robin-checkmk
Add new demo playbooks for rules and a full run.
9df15fc
@robin-checkmk
Add logic to skip breaks.
14cc352
@robin-checkmk
Add Checkmk 2.2 beta to integration tests.
409b7c6
@robin-checkmk
Merge branch 'devel' into feature-2-2-support
d6bea8c
@robin-checkmk
Add molecule scenario for 2.2.
7a6ee7e 
WIP
@robin-checkmk
Fix name key.
1f676e7
@robin-checkmk
Add explicit strategy to playbooks.
f3497ec
@robin-checkmk
Bugfix README.
22f7576
@robin-checkmk
Extend rule module integration tests.
cec4db1
@sscmh
PR changes made as requested.
175ca87 
RedHat.yml now uses ansible_distribution_file_variety now.
Therefor redundany is removed from the code and maybe it works too for other Centos lookalike distributions, like e.g. RockyLinux, Springdate, etc.
@sscmh
Merge branch 'tribe29:main' into main
8efcba3
@sscmh
basic test folder ok, work-in-progress ...
e30f59f
@sscmh
tested on DevSB (sandbox)
424aadc
@sscmh
hotfix for create_folders, wip
1cb3a67
@sscmh
resorted tags (work-in-progress)
71dfec4
@sscmh
removed again
fe8db96
@godspeed-you
Introduce api.py as central library for API calls to Checkmk
ce7ff64
@godspeed-you
Update api.py
8de61ea
@godspeed-you
Update activation.py
af570f6
@godspeed-you
updating format in api.py
d2cf503
@godspeed-you
remove pylint comments
7e0e0c8 
These has been used during the change process.
@dependabot
Bump actions/stale from 7 to 8
d49e30c 
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@lgetwan
User module - Fix creation of automation users.
babb312
@lgetwan
User module - Updated the integration tests, as well.
85345f5
@msekania
Copy link
Contributor

@robin-checkmk,

How does it work, I think I have followed the described steps, but still get an error

@robin-checkmk
Copy link
Member Author

@msekania you need to post the following statement as a comment here, to confirm, that you agree to the CLA.

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@msekania
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@robin-checkmk robin-checkmk marked this pull request as ready for review May 22, 2023 09:34
@msekania
Copy link
Contributor

@robin-checkmk

one should make readme fro CLA more clear.

@robin-checkmk
Copy link
Member Author

Everyone that was mentioned by the CLA Bot but did not contribute to this PR: I apologize for the inconvenience! I had to perform some git-magic, that went sideways. If you could just sign the CLA real quick, that would be great!

For those, where the bot did not find a GitHub account: Please follow the linked guide. That would be:

If there are any questions, do let me know.

@Max-checkmk
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@Lars
Copy link

Lars commented May 23, 2023

Everyone that was mentioned by the CLA Bot but did not contribute to this PR: I apologize for the inconvenience! I had to perform some git-magic, that went sideways. If you could just sign the CLA real quick, that would be great!

For those, where the bot did not find a GitHub account: Please follow the linked guide. That would be:

If there are any questions, do let me know.

I'm sorry if I'm misunderstanding, you're requesting I sign the CLA in the name of somebody else for the PR to go through even though I have taken no part of this PR?

@Lars
Copy link

Lars commented May 23, 2023

If so, the bot will fail if I include any other text than the aforementioned line in the message? As I want to make clear I or my organization have not contributed any work to this push and I have not signed a CLA with this project.

@robin-checkmk
Copy link
Member Author

I'm sorry if I'm misunderstanding, you're requesting I sign the CLA in the name of somebody else for the PR to go through even though I have taken no part of this PR?

Hi @Lars and sorry for the misunderstanding.
Of course, you should not sign anything here, you were mentioned by the bot on accident. Please just ignore this, we are trying to clean things up. The same goes for @Geoffroy of course.

@lgetwan
Copy link
Contributor

lgetwan commented May 25, 2023

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@robin-checkmk
Copy link
Member Author

Hi everyone!

Once again apologies for the noise and potential confusion in this PR!
I will be off for two weeks now and will merge this PR after my return.
It would be lovely to see missing signatures by then. Thanks!

See you in roughly two weeks!

lgetwan
lgetwan approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most code changes have been reviewed by me when merged into the devel branch.
I just checked the rest of the changes for consistency.

@robin-checkmk robin-checkmk merged commit 40a1153 into main Jun 7, 2023
202 of 203 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgetwan lgetwan lgetwan approved these changes

Assignees

@robin-checkmk robin-checkmk

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@robin-checkmk @msekania @Max-checkmk @Lars @lgetwan @sscmh @godspeed-you @ogaida @nico-checkmk @englertor