Use compare_html helper for new help rendering code unit tests

Change-Id: Iead2f7b71f1d36d00bfd2468d395cf48ee698f69
Checkmk · Oct 28, 2019 · 679d844 · 679d844
1 parent 41460dc
commit 679d844
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/cmk/gui/htmllib.py b/cmk/gui/htmllib.py
@@ -1545,7 +1545,7 @@ def render_help(self, text):
         help_text = self._resolve_help_text_macros(stripped)
 
         self.enable_help_toggle()
-        style = "display: %s;" % ("block" if self.help_visible else "none")
+        style = "display:%s;" % ("block" if self.help_visible else "none")
         return self.render_div(HTML(help_text), class_="help", style=style)
 
     def _resolve_help_text_macros(self, text):

diff --git a/tests/unit/cmk/gui/test_htmllib_html_cls.py b/tests/unit/cmk/gui/test_htmllib_html_cls.py
@@ -2,6 +2,7 @@
 from cmk.gui.globals import html
 from cmk.gui.htmllib import HTML
 import cmk.gui.config as config
+from tools import compare_html
 
 
 def test_render_help_empty(register_builtin_html):
@@ -18,32 +19,36 @@ def test_render_help_empty(register_builtin_html):
 
 def test_render_help_html(register_builtin_html):
     assert html.have_help is False
-    assert html.render_help(
-        HTML("<abc>")) == HTML("<div style=\"display: none;\" class=\"help\"><abc></div>")
+    assert compare_html(html.render_help(HTML("<abc>")),
+                        HTML("<div style=\"display:none\" class=\"help\"><abc></div>"))
     assert html.have_help is True
 
 
 def test_render_help_text(register_builtin_html):
-    assert html.render_help(u"äbc") == HTML(
-        u"<div style=\"display: none;\" class=\"help\">äbc</div>")
+    assert compare_html(html.render_help(u"äbc"),
+                        HTML(u"<div style=\"display:none\" class=\"help\">äbc</div>"))
 
 
 def test_render_help_visible(register_builtin_html):
     assert html.help_visible is False
     html.help_visible = True
-    assert html.render_help(u"äbc") == HTML(
-        u"<div style=\"display: block;\" class=\"help\">äbc</div>")
+    assert compare_html(html.render_help(u"äbc"),
+                        HTML(u"<div style=\"display:block\" class=\"help\">äbc</div>"))
 
 
 def test_add_manual_link(register_builtin_html):
     assert config.user.language() is None
-    assert html.render_help(u"[cms_introduction_docker|docker]") == HTML(
-        u"<div style=\"display: none;\" class=\"help\"><a href=\"https://checkmk.com/cms_introduction_docker.html\" target=\"_blank\">docker</a></div>"
-    )
+    assert compare_html(
+        html.render_help(u"[cms_introduction_docker|docker]"),
+        HTML(
+            u"<div style=\"display:none\" class=\"help\"><a href=\"https://checkmk.com/cms_introduction_docker.html\" target=\"_blank\">docker</a></div>"
+        ))
 
 
 def test_add_manual_link_localized(register_builtin_html, monkeypatch):
     monkeypatch.setattr(config.user, "language", lambda: "de")
-    assert html.render_help(u"[cms_introduction_docker|docker]") == HTML(
-        u"<div style=\"display: none;\" class=\"help\"><a href=\"https://checkmk.de/cms_introduction_docker.html\" target=\"_blank\">docker</a></div>"
-    )
+    assert compare_html(
+        html.render_help(u"[cms_introduction_docker|docker]"),
+        HTML(
+            u"<div style=\"display:none\" class=\"help\"><a href=\"https://checkmk.de/cms_introduction_docker.html\" target=\"_blank\">docker</a></div>"
+        ))