precommit: fix problems when checking multiple files

Change-Id: I44f5761e4f5e8e4f011a54f03464fc32db423686
Checkmk · Jan 8, 2020 · a9722a8 · a9722a8
1 parent bae9453
commit a9722a8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -34,7 +34,7 @@ repos:
       hooks:
           - id: yapf
             name: Check yapf
-            entry: scripts/check-yapf
+            entry: scripts/check-yapf -i
             language: script
             types: [file, python]
           - id: pylint

diff --git a/scripts/check-mypy b/scripts/check-mypy
@@ -2,6 +2,7 @@
 #
 # This file is for execution by the pre-commit framework.
 #
+set -e -o pipefail
 
 source "$(dirname $0)/lib-precommit"
 

diff --git a/scripts/check-pylint b/scripts/check-pylint
@@ -2,6 +2,7 @@
 #
 # This file is for execution by the pre-commit framework.
 #
+set -e -o pipefail
 
 source "$(dirname $0)/lib-precommit"
 
@@ -13,9 +14,9 @@ PYTHON2_FILES=$(python_files 2 "$files")
 PYTHON3_FILES=$(python_files 3 "$files")
 
 if [ ! -z "$PYTHON3_FILES" ]; then
-    $PIPENV 3 run pylint "$PYTHON3_FILES"
+    $PIPENV 3 run pylint $PYTHON3_FILES
 fi
 
 if [ ! -z "$PYTHON2_FILES" ]; then
-    $PIPENV 2 run pylint "$PYTHON2_FILES"
+    $PIPENV 2 run pylint $PYTHON2_FILES
 fi
diff --git a/scripts/check-yapf b/scripts/check-yapf
@@ -21,9 +21,9 @@ PYTHON2_FILES=$(python_files 2 "$files")
 PYTHON3_FILES=$(python_files 3 "$files")
 
 if [ ! -z "$PYTHON3_FILES" ]; then
-    $PIPENV 3 run yapf $ARGS "$PYTHON3_FILES"
+    $PIPENV 3 run yapf $ARGS $PYTHON3_FILES
 fi
 
 if [ ! -z "$PYTHON2_FILES" ]; then
-    $PIPENV 2 run yapf $ARGS "$PYTHON2_FILES"
+    $PIPENV 2 run yapf $ARGS $PYTHON2_FILES
 fi