Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended scan function of ibm_tape_library.py to be able to discover … #593

Closed
wants to merge 1 commit into from
Closed

Extended scan function of ibm_tape_library.py to be able to discover … #593

wants to merge 1 commit into from

Conversation

t29j
Copy link
Contributor

@t29j t29j commented May 16, 2023

This patch is only against the 2.1.0 branch, because in the master branch, the scan function is not in ~/lib/python3/cmk/base/check_legacy_includes/ibm_tape_library.py anymore

…IBM TS4300 Tape Library

Extended scan function of ibm_tape_library.py to be able to discover IBM TS4300 Tape Library

References

…IBM TS4300 Tape Library

Extended scan function of ibm_tape_library.py to be able to discover IBM TS4300 Tape Library

https://forum.checkmk.com/t/ibm-ts-4300-got-empty-snmp-response/31004

SUP-12553
SUP-14102
@scolakovic scolakovic self-assigned this May 16, 2023
@scolakovic
Copy link
Contributor

Hi,
can you submit this change to the Exchange?
The reason why I don't want to merge it to official Checkmk code is that it would cause slower SNMP device discovery for all SNMP user, even the ones that don't have the IBM Tape Library.
Detect functions that fetch OIDs different than system description (.1.3.6.1.2.1.1.1.0) and system object ID (.1.3.6.1.2.1.1.2.0) in every case (detect rules are lazy evaluated), cause the additional OID to be fetched for all SNMP devices.

@t29j
Copy link
Contributor Author

t29j commented May 23, 2023

Hi scolakovic,

thanks for your efforts so far!

I totally understand that the missing system object ID (.1.3.6.1.2.1.1.2.0) of this sh1tty IBM device is a problem
and that you do not want to slow down all plugins by that.

I do not have time to create and maintain an mkp on exchange.checkmk.com
Perhaps I will ask in the forum is somebody else is willing to do it.

I am fine if you close this pull request without merging it.

But again it shows how hard is sometimes do support a device and get the code into the master.

@scolakovic scolakovic closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants