Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gcc version and sysroot #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump gcc version and sysroot #1

wants to merge 3 commits into from

Conversation

TimotheusBachinger
Copy link
Collaborator

  • Bump bazel version to 7.1.1
  • Switch toolchain to gcc 13.2.0 + glibc 2.22

@TimotheusBachinger
Adds a failing configure_make target
3be3a14 
Use: bazel build --sandbox_add_mount_pair=/tmp  --sandbox_debug --verbose_failures --platforms=//platforms:x86_64_linux //examples/rrdtool:rrdtool
Synss
Synss reviewed Apr 23, 2024
View reviewed changes
examples/rrdtool/BUILD
"--disable-tcl",
"--with-systemdsystemunitdir=no",
# https://github.com/bazelbuild/rules_foreign_cc/issues/239
"CFLAGS='-Dredacted=\"redacted\"'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that doesn't append but replaces the CFLAGS.
However, Bazel passes the include directories to the compiler with CFLAGS=-isystem .... Replacing CFLAGS means no header is found and configure fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synss Synss Synss left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Synss Synss

@frans-fuerst frans-fuerst

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TimotheusBachinger @Synss @frans-fuerst