Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Twig for email rendering #38

Closed
Chemaclass opened this issue Jan 21, 2020 · 0 comments
Closed

Use Twig for email rendering #38

Chemaclass opened this issue Jan 21, 2020 · 0 comments
Assignees
@Chemaclass @JesusValera
Labels
enhancement New feature or request improvement Refactoring or cleaning related

Comments

@Chemaclass
Copy link
Owner

Chemaclass commented Jan 21, 2020 •
edited

Current behavior

Currently, we generate the email template directly in src/ScrumMaster/Channel/Email/MessageGenerator.php.

We already installed twig, and use it in the output example.

Acceptance Criteria

  • Use Twig inside the MessageGenerator (or similar).
  • Decouple the logic from the rendering.
@Chemaclass Chemaclass added enhancement New feature or request improvement Refactoring or cleaning related labels Jan 21, 2020
@Chemaclass Chemaclass self-assigned this Mar 13, 2020
@Chemaclass Chemaclass mentioned this issue Mar 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chemaclass Chemaclass

@JesusValera JesusValera

Labels
enhancement New feature or request improvement Refactoring or cleaning related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chemaclass @JesusValera