Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create email-template.twig #46

Merged
merged 2 commits into from Mar 16, 2020
Merged

Create email-template.twig #46

merged 2 commits into from Mar 16, 2020

Conversation

Chemaclass
Copy link
Owner

Description

Instead of having the "email body" in a PHP class I would prefer if the "view" part would it be in a separate twig file.

I encapsulated the template view where is rendered the email content in a file called "email-template.twig"

Issue: #38

@Chemaclass Chemaclass added the improvement Refactoring or cleaning related label Mar 15, 2020
@Chemaclass Chemaclass self-assigned this Mar 15, 2020
@Chemaclass Chemaclass added this to In progress in Notify throw different channels via automation Mar 15, 2020
JesusValera
JesusValera approved these changes Mar 15, 2020
View reviewed changes
Copy link
Collaborator

@JesusValera JesusValera left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you decoupled the email view from the code! 🚀 🥇
No comments!!

@Chemaclass Chemaclass merged commit 2404647 into master Mar 16, 2020
@Chemaclass Chemaclass deleted the 38-twig-for-email-rendering branch March 16, 2020 12:53
@Chemaclass Chemaclass moved this from In progress to Done in Notify throw different channels Mar 16, 2020
@Chemaclass Chemaclass mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusValera JesusValera JesusValera approved these changes

Assignees

@Chemaclass Chemaclass

Labels
improvement Refactoring or cleaning related
Projects
No open projects
Notify throw different channels
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chemaclass @JesusValera