Applying psalm immutable + psalm.level=1 #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm trying to get rid of the classes' states in order to make them immutable.
For example, the class
SegmentedValues
had a propertylists
which it was mutable: the methodfromRaw()
was mutating that state(lists: array), instead of having that property, why not create a pure function without side effects? So that's what this PR is about. Getting rid of state mutation in favor of pure functions which doesn't have side effects but returning the value that we want.In order to get rid of the
array<array<string, array<string, SegmentInterface>>>
return type, I encapsulate each "transaction message" into the classTransactionMessage
, which contains exactly all their grouped segments.Doing this approach we don't need to rely on arrays offsets to get their values but a method