add DummyFeaturization #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
…ved `decode(::AtomGraph)` from graphnodefeaturization to atomgraph, also added some generic methods and imports/exports. Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
…exports so existing tests pass Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
…ormatting Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
…d validate_features Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
This was referenced Jun 23, 2021
Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 81.08% 82.50% +1.41%
==========================================
Files 11 13 +2
Lines 312 320 +8
==========================================
+ Hits 253 264 +11
+ Misses 59 56 -3
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @test_throws ArgumentError decode(df, dummy_encoded) | ||
| F2 = AtomGraph(Float32.([0 1; 1 0]), ["F", "F"]) | ||
| @test_throws ArgumentError featurize!(F2, df) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
Signed-off-by: Rachel Kurchin <rkurchin@cmu.edu>
Merged
|
This approach is being abandoned, at least for now, and the docstring commits have been grabbed over in #90, so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85 .