Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example URL #2

Merged
merged 4 commits into from
Feb 23, 2020
Merged

fix example URL #2

merged 4 commits into from
Feb 23, 2020

Conversation

tomByrer
Copy link
Contributor

didn't work; color was too short

I assume this will also fix the landing page?

didn't work; color was too short
@Cherry
Copy link
Owner

Cherry commented Feb 22, 2020

Thanks for the PR! The landing page is just a static index.html in the public folder if you wouldn't mind updating that too? (There's no fancy build-chain here yet).

@Cherry
Copy link
Owner

Cherry commented Feb 22, 2020

Also, the example URL seems to work just fine for me? It's probably missing a textColor such as https://images.placeholders.dev/?width=350&height=100&text=Hello%20World&bgColor=%23000&textColor=rgba(255,255,255,0.5), but the short bgColor seems to work fine here? Perhaps it's a browser-specific thing?

@tomByrer
Copy link
Contributor Author

Perhaps it's a browser-specific thing?

Maybe, Firefox Dev on Win10. Dark mode but perhaps shouldn't matter?

placeholder-dev-demo-firefox

@tomByrer
Copy link
Contributor Author

Hold on, I have a better idea 🌱

@tomByrer tomByrer reopened this Feb 23, 2020
@tomByrer
Copy link
Contributor Author

A little more advertising never hurts ;)

@Cherry
Copy link
Owner

Cherry commented Feb 23, 2020

Thanks, merged!

@Cherry Cherry merged commit 97460d8 into Cherry:master Feb 23, 2020
@tomByrer tomByrer deleted the patch-1 branch February 23, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants