08/07/24 form filler #214
Merged
08/07/24 form filler #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patanj101
reviewed
Jul 9, 2024
app/services/applier/form_filler.rb
Outdated
Comment on lines
28
to
37
| def process | ||
| p "Hello from FormFiller!" | ||
| submit_application | ||
| visit_url | ||
| click_apply_button | ||
| fill_in_all_fields | ||
| sleep 2 | ||
| click_submit_button | ||
| confirm_submission_was_successful | ||
| ensure | ||
| @session.quit | ||
| end |
There was a problem hiding this comment.
What about something like this instead ?
def process
visit_url
fill_application_form
click_submit_button
# sleep 2 add this to click_submit_button
verify_submission # instead of confirm_submission_was_successful
ensure
@session.quit
end
private
def fill_application_form
click_apply_button
fill_in_all_fields
end
def verify_submission
# Add logic to check for successful submission message or other indicators
end
|
@daniel-sussman good stuff. I left a comment for improvement. |
Ches-ctrl
approved these changes
Jul 15, 2024
| # file = File.open(screenshot_path) | ||
| # job_app = job_application | ||
| # job_app.screenshot.attach(io: file, filename: "screenshot-#{job_application.id}.png", content_type: 'image/png') | ||
| def doc_tmp_file |
There was a problem hiding this comment.
This is one to go into more detail on later with JB on how we want to handle files - he was discussing markdown for cover letters for example
| end | ||
| end | ||
|
|
||
| def handle_upload |
| find(:css, "input[type='text']", focused: true).set(follow_up_value) | ||
| end | ||
|
|
||
| def handle_demographic_question |
There was a problem hiding this comment.
Nice custom logic - one to iterate on over time and see if we can improve
There was a problem hiding this comment.
Flag on Greenhouse - sometimes there's a security confirmation field that pops up (it sits hidden in the HTML) - think we will likely need to add this in due course
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.